<html>
<head><meta charset="utf-8"><title>ignore-pass · general · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/index.html">general</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html">ignore-pass</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="172341828"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172341828" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172341828">(Aug 02 2019 at 20:58)</a>:</h4>
<p>Is it just me or is the new <code>ignore-pass</code> directive for UI tests confusing? Usually <code>ignore-X</code> means "ignore this test if X applies", like <code>ignore-windows</code> or <code>ignore-x86</code> or so. but <code>ignore-pass</code> means "ignore <code>--pass</code> argument"...</p>



<a name="172341863"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172341863" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172341863">(Aug 02 2019 at 20:58)</a>:</h4>
<p><span class="user-mention" data-user-id="126931">@centril</span> AFAIK you were involved in the recent UI test changes</p>



<a name="172341895"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172341895" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172341895">(Aug 02 2019 at 20:59)</a>:</h4>
<p><span class="user-mention" data-user-id="120791">@RalfJ</span> I think it could be better named</p>



<a name="172341906"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172341906" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172341906">(Aug 02 2019 at 20:59)</a>:</h4>
<p>ideally the directive shouldn't exist</p>



<a name="172341918"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172341918" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172341918">(Aug 02 2019 at 20:59)</a>:</h4>
<p>I also find <code>--pass build</code> confusing TBH</p>



<a name="172341931"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172341931" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172341931">(Aug 02 2019 at 20:59)</a>:</h4>
<p>elaborate?</p>



<a name="172341938"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172341938" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172341938">(Aug 02 2019 at 20:59)</a>:</h4>
<p>it reads to be either as "pass <code>build</code> to... something (as an argument)" or "make all build tests pass" or so</p>



<a name="172342017"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342017" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342017">(Aug 02 2019 at 21:00)</a>:</h4>
<p><span class="user-mention" data-user-id="120791">@RalfJ</span> I see yes... I think it's a concession to brevity</p>



<a name="172342027"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342027" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342027">(Aug 02 2019 at 21:00)</a>:</h4>
<p>I would love to find something relatively as brief but more clear</p>



<a name="172342034"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342034" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342034">(Aug 02 2019 at 21:00)</a>:</h4>
<p>other times it sounds like doing something with "the build pass"</p>



<a name="172342046"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342046" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342046">(Aug 02 2019 at 21:01)</a>:</h4>
<p>"pass" is just way too overloaded in compilers/languages^^</p>



<a name="172342047"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342047" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342047">(Aug 02 2019 at 21:01)</a>:</h4>
<p>but it's something of a tall order to improve clarity without making it longer</p>



<a name="172342052"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342052" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342052">(Aug 02 2019 at 21:01)</a>:</h4>
<p>yeah</p>



<a name="172342054"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342054" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342054">(Aug 02 2019 at 21:01)</a>:</h4>
<p>fwiw, it does have a help explanation ^^</p>



<a name="172342077"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342077" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342077">(Aug 02 2019 at 21:01)</a>:</h4>
<p>but <code>// ignore-pass</code> could be longer if that helps</p>



<a name="172342118"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342118" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342118">(Aug 02 2019 at 21:02)</a>:</h4>
<p>maybe <code>// ignore-pass-flag</code></p>



<a name="172342133"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342133" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342133">(Aug 02 2019 at 21:02)</a>:</h4>
<p>Ideally we would remove the need for it tho</p>



<a name="172342138"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342138" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342138">(Aug 02 2019 at 21:02)</a>:</h4>
<p>that's where I'd spend my energy</p>



<a name="172342169"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342169" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342169">(Aug 02 2019 at 21:03)</a>:</h4>
<p>I think t cannot start with <code>ignore</code></p>



<a name="172342174"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342174" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342174">(Aug 02 2019 at 21:03)</a>:</h4>
<p><code>pass-ignore</code> or so might work</p>



<a name="172342186"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342186" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342186">(Aug 02 2019 at 21:03)</a>:</h4>
<p>"force {check,build,run}-pass tests to this mode."<br>
so a test that's usually check-pass will be run when using <code>--pass run</code>?</p>



<a name="172342201"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342201" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342201">(Aug 02 2019 at 21:03)</a>:</h4>
<p><span class="user-mention" data-user-id="120791">@RalfJ</span> correct</p>



<a name="172342245"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342245" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342245">(Aug 02 2019 at 21:04)</a>:</h4>
<p>hm, odd. I would have expected a cap instead</p>



<a name="172342249"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342249" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342249">(Aug 02 2019 at 21:04)</a>:</h4>
<p>seems weird to test <em>more</em> than what the test itself says to test</p>



<a name="172342253"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342253" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342253">(Aug 02 2019 at 21:04)</a>:</h4>
<p><span class="user-mention" data-user-id="120791">@RalfJ</span>  that was my thinking originally</p>



<a name="172342261"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342261" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342261">(Aug 02 2019 at 21:04)</a>:</h4>
<p>not sure why it changed</p>



<a name="172342273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342273">(Aug 02 2019 at 21:04)</a>:</h4>
<p>9/10 times you want <code>--pass check</code> anyways</p>



<a name="172342301"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342301" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342301">(Aug 02 2019 at 21:05)</a>:</h4>
<p>maybe it should be changed to a cap;</p>
<p>cc <span class="user-mention" data-user-id="123856">@Vadim Petrochenkov</span></p>



<a name="172342350"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342350" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342350">(Aug 02 2019 at 21:05)</a>:</h4>
<p><code>--check</code>/<code>--build</code>/<code>--run</code> might work as flags</p>



<a name="172342417"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342417" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342417">(Aug 02 2019 at 21:06)</a>:</h4>
<p>sure</p>



<a name="172342418"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342418" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342418">(Aug 02 2019 at 21:06)</a>:</h4>
<p>its more flags, but its both shorter and less confusing than the current situation IMO</p>



<a name="172342457"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342457" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342457">(Aug 02 2019 at 21:06)</a>:</h4>
<p>The current situation works for me tho so I'm not going to change it myself but if you feel strongly make an issue or something :P</p>



<a name="172342477"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342477" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342477">(Aug 02 2019 at 21:07)</a>:</h4>
<p>I'll see if I get bored over the weekend ;)</p>



<a name="172342483"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172342483" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172342483">(Aug 02 2019 at 21:07)</a>:</h4>
<p><span aria-label="joy" class="emoji emoji-1f602" role="img" title="joy">:joy:</span></p>



<a name="172343358"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172343358" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172343358">(Aug 02 2019 at 21:20)</a>:</h4>
<p><code>--pass run</code> is needed.<br>
Over the time tests will be migrated to weaker testing modes (like <code>// check-pass</code>) and weird unpredictable codegen bugs will inevitably slip through this weaker testing.<br>
Occasional (or regular, if CI allows) <code>--pass run</code> runs will ensure that it doesn't happen.</p>



<a name="172343496"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172343496" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172343496">(Aug 02 2019 at 21:23)</a>:</h4>
<p>I originally wanted to implement the full spectrum of pass mode tweaks - <code>&gt;=mode</code>, <code>&lt;=mode</code> etc.<br>
The initial implementation only did <code>==mode</code>, but that's not the end of the story.</p>



<a name="172343693"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172343693" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172343693">(Aug 02 2019 at 21:26)</a>:</h4>
<p>I don't like <code>--check</code>/<code>--build</code>/<code>--run</code> because the options apply only to <code>pass</code> tests.<br>
<code>run-fail</code> tests will still be fully built and run even in the <code>--pass check</code> mode.</p>



<a name="172343774"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172343774" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172343774">(Aug 02 2019 at 21:27)</a>:</h4>
<blockquote>
<p>I originally wanted to implement the full spectrum of pass mode tweaks - &gt;=mode, &lt;=mode etc.</p>
</blockquote>
<p>That said, I didn't need the modes using the "cap" meaning yet.</p>



<a name="172343788"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172343788" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172343788">(Aug 02 2019 at 21:27)</a>:</h4>
<p>but it is entirely unclear that "pass" is an adjective for the kind of test here</p>



<a name="172343794"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172343794" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172343794">(Aug 02 2019 at 21:28)</a>:</h4>
<p>almost always it is used as a verb or a noun</p>



<a name="172343846"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172343846" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172343846">(Aug 02 2019 at 21:28)</a>:</h4>
<p>so even with your valid criticism I still think the bare flags are clearer^^</p>



<a name="172343851"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172343851" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172343851">(Aug 02 2019 at 21:28)</a>:</h4>
<p><code>--pass-mode</code>?</p>



<a name="172343867"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172343867" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172343867">(Aug 02 2019 at 21:29)</a>:</h4>
<p>still snaps to a verb in my brain</p>



<a name="172343889"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172343889" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172343889">(Aug 02 2019 at 21:29)</a>:</h4>
<p>It's just a thing for every day use, so I'd personally prefer it to be short and people being sent to read what it does in the docs.</p>



<a name="172343890"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172343890" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172343890">(Aug 02 2019 at 21:29)</a>:</h4>
<p>maybe <code>passing</code> works better than <code>pass</code>?</p>



<a name="172343967"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172343967" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172343967">(Aug 02 2019 at 21:30)</a>:</h4>
<p>though <code>-fail</code> tests also better pass^^</p>



<a name="172343975"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172343975" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172343975">(Aug 02 2019 at 21:30)</a>:</h4>
<p>IOW, the terminology is confusing even outside the flag</p>



<a name="172344016"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172344016" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172344016">(Aug 02 2019 at 21:31)</a>:</h4>
<p>¯\_(ツ)_/¯</p>



<a name="172344095"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172344095" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172344095">(Aug 02 2019 at 21:32)</a>:</h4>
<blockquote>
<p>but it is entirely unclear that "pass" is an adjective for the kind of test here</p>
</blockquote>
<p><code>--pass</code> is a verb though?</p>



<a name="172344113"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172344113" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172344113">(Aug 02 2019 at 21:32)</a>:</h4>
<p>pass [through a] build, pass [through a] run</p>



<a name="172344152"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172344152" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172344152">(Aug 02 2019 at 21:33)</a>:</h4>
<p>oh that's how you think about it</p>



<a name="172344161"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172344161" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172344161">(Aug 02 2019 at 21:33)</a>:</h4>
<p>the verb I meant is to "pass an argument" or "pass sth along"</p>



<a name="172344218"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172344218" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172344218">(Aug 02 2019 at 21:34)</a>:</h4>
<p>I wonder why <code>run-pass</code> was originally not named <code>pass-run</code>...</p>



<a name="172344295"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172344295" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172344295">(Aug 02 2019 at 21:35)</a>:</h4>
<p>Probably because the "more important" thing were put first?</p>



<a name="172344358"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172344358" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172344358">(Aug 02 2019 at 21:36)</a>:</h4>
<p><code>--run-pass</code>, <code>--check-pass</code>, <code>--build-pass</code>?</p>



<a name="172344396"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172344396" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172344396">(Aug 02 2019 at 21:37)</a>:</h4>
<p>maybe it's just because I have seen "run-pass" for years now, but those "click" the right way for me</p>



<a name="172344423"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172344423" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172344423">(Aug 02 2019 at 21:37)</a>:</h4>
<p><code>--run-pass</code> etc LGTM.</p>



<a name="172344436"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172344436" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172344436">(Aug 02 2019 at 21:37)</a>:</h4>
<p>Will be harder to extend the syntax to <code>&gt;=</code> naturally though.</p>



<a name="172344496"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172344496" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172344496">(Aug 02 2019 at 21:38)</a>:</h4>
<p>(If it ever becomes necessary at all.)</p>



<a name="172344520"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172344520" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172344520">(Aug 02 2019 at 21:38)</a>:</h4>
<p>yeah</p>



<a name="172344563"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172344563" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172344563">(Aug 02 2019 at 21:39)</a>:</h4>
<p><code>--run-pass</code> also looks like a filter, like "run the <code>run-pass</code> tests only".</p>



<a name="172399850"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/ignore-pass/near/172399850" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/ignore-pass.html#172399850">(Aug 03 2019 at 09:43)</a>:</h4>
<p>I dont think it looks any <em>more</em> like a filter than <code>--pass run</code></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>